Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint/code versions #717

Merged
merged 1 commit into from Jun 13, 2017

Conversation

@geek
Copy link
Member

geek commented Jun 13, 2017

Fixes #715

@geek geek self-assigned this Jun 13, 2017
@geek geek added this to the 14.0.0 milestone Jun 13, 2017
@geek geek requested a review from devinivy Jun 13, 2017
Copy link
Member

Marsup left a comment

All good.

@@ -105,7 +105,7 @@ exports.generate = function (options) {
(options.lint &&
(internals.isOverLintStatus(notebook.lint, options['lint-errors-threshold'], 'ERROR') || // Linting errors
internals.isOverLintStatus(notebook.lint, options['lint-warnings-threshold'], 'WARNING') // Linting warnings
)) ? 1 : 0;
)) ? 1 : 0;

This comment has been minimized.

Copy link
@Marsup

Marsup Jun 13, 2017

Member

Should you have the last parenthesis on a new line ?

This comment has been minimized.

Copy link
@geek

geek Jun 13, 2017

Author Member

Fixed

@geek geek force-pushed the geek:master branch from a97c120 to 02a806c Jun 13, 2017
@geek geek requested review from Marsup and removed request for devinivy Jun 13, 2017
@geek geek merged commit f76ff05 into hapijs:master Jun 13, 2017
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.