Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint 4 ignore path #720

Merged
merged 1 commit into from Jun 13, 2017

Conversation

@geek
Copy link
Member

geek commented Jun 13, 2017

Updates from eslint 4 now move the eslintignore to be relative to the file, which means installing lab v14 before this change without a top level .eslintignore uses the one from lab, which results in node_modules being linted :/ This fixes that bug

Another part of this fix is to not search beyond the cwd for an eslintrc file

@geek geek self-assigned this Jun 13, 2017
@geek geek added this to the 14.0.1 milestone Jun 13, 2017
@geek geek added the bug label Jun 13, 2017
@geek geek force-pushed the geek:master branch from 0c7c9d9 to 068f77d Jun 13, 2017
@geek geek merged commit 6436d77 into hapijs:master Jun 13, 2017
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.