Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm 5.2 error #726

Merged
merged 1 commit into from Jul 13, 2017

Conversation

@Marsup
Copy link
Member

Marsup commented Jul 12, 2017

npm 5.2 stopped hoisting modules or whatever, so eslint doesn't find its modules anymore, I think having the full path satisfies whatever npm version there is.

@Marsup Marsup added the bug label Jul 12, 2017
@Marsup Marsup requested a review from geek Jul 12, 2017
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Jul 12, 2017

Failure unrelated to this PR.

@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Jul 12, 2017

It's going to be reverted (see npm/npm#17717). I don't know if it's useful to keep that then. Thoughts ?

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Jul 12, 2017

It might be more bullet proof to keep this change in place.

@geek geek added this to the 14.1.1 milestone Jul 13, 2017
@geek geek self-assigned this Jul 13, 2017
@geek geek merged commit 3500265 into master Jul 13, 2017
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
Node Security No known vulnerabilities found
Details
@geek geek deleted the npm-fix branch Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.