Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add object spread option #740

Merged
merged 2 commits into from Aug 25, 2017
Merged

add object spread option #740

merged 2 commits into from Aug 25, 2017

Conversation

@wzrdtales
Copy link
Contributor

wzrdtales commented Aug 25, 2017

Maybe it would make sense to let users pass in their own config.

Fixes #739

@wzrdtales wzrdtales force-pushed the wzrdtales:addObjectSpread branch from ad9b007 to f173bf0 Aug 25, 2017
@wzrdtales

This comment has been minimized.

Copy link
Contributor Author

wzrdtales commented Aug 25, 2017

sry forgot to deactive prettier... overwritten now with an unfixed version

@@ -251,6 +251,9 @@ internals.instrument = function (filename) {
loc: true,
comment: true,
range: true,
ecmaFeatures: {
experimentalObjectRestSpread: true

This comment has been minimized.

Copy link
@geek

geek Aug 25, 2017

Member

need to indent this a tad more, that is why the CI is failing

This comment has been minimized.

Copy link
@wzrdtales

wzrdtales Aug 25, 2017

Author Contributor

yeh before prettier did reindint just everything and now I missed it ;) Would be awesome if you could add an .eslintrc to your project so prettier can do that stuff for me :)

This comment has been minimized.

This comment has been minimized.

Copy link
@wzrdtales

wzrdtales Aug 25, 2017

Author Contributor

@cjihrig That should be in the project root actually.

This comment has been minimized.

Copy link
@cjihrig

cjihrig Aug 25, 2017

Contributor

Nonetheless, that's where it is if you want to access it.

@geek geek self-assigned this Aug 25, 2017
@geek geek added feature bug and removed feature labels Aug 25, 2017
@geek geek added this to the 14.2.1 milestone Aug 25, 2017
@wzrdtales

This comment has been minimized.

Copy link
Contributor Author

wzrdtales commented Aug 25, 2017

Now it fails b/c it actually lints /home/travis/build/hapijs/lab/README.md oO

@geek geek merged commit 3d8b49e into hapijs:master Aug 25, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Node Security No known vulnerabilities found
Details
@geek

This comment has been minimized.

Copy link
Member

geek commented Aug 25, 2017

@wzrdtales published as 14.2.1

@wzrdtales

This comment has been minimized.

Copy link
Contributor Author

wzrdtales commented Aug 25, 2017

+1

@temsa

This comment has been minimized.

Copy link

temsa commented Aug 25, 2017

🎉

@wzrdtales wzrdtales deleted the wzrdtales:addObjectSpread branch Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.