Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better color detection #744

Merged
merged 1 commit into from Aug 31, 2017
Merged

Better color detection #744

merged 1 commit into from Aug 31, 2017

Conversation

@Marsup
Copy link
Member

Marsup commented Aug 31, 2017

For a while now, I've never been able to see lab colors on WebStorm console, which is especially annoying for diffs, and I finally found out why.

Turns out that detecting whether it's a TTY or not is not enough to tell if it supports color.

@Marsup Marsup added the bug label Aug 31, 2017
@Marsup Marsup requested a review from geek Aug 31, 2017
@geek geek added this to the 14.2.2 milestone Aug 31, 2017
@geek geek merged commit 51e1e98 into master Aug 31, 2017
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the better-color-detection branch Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.