Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domains and callbacks #766

merged 1 commit into from Oct 23, 2017


Copy link

geek commented Oct 12, 2017

Closes #752
Closes #765

  • Remove support for (done) callback on tests
  • Move to flags object passed into tests with onCleanup and note functions
  • Removed support for parallel mode
  • Removed debug mode, this is now always on
  • Removed code as the default assertion library and removed the -a false option
@geek geek requested review from hueniverse and Marsup Oct 12, 2017
@geek geek added this to the 15.0.0 milestone Oct 12, 2017
@geek geek changed the title remove domains and callbacks Remove domains and callbacks Oct 12, 2017
@geek geek requested a review from cjihrig Oct 16, 2017
(async () => {
try {
const { code } = await require('../test_runner/cli').run();

This comment has been minimized.

Copy link

cjihrig Oct 16, 2017


Indentation looks off here.

"code": "4.1.x",
"diff": "3.3.x",
"eslint": "4.7.x",
"code": "5.1.x",

This comment has been minimized.

Copy link

hueniverse Oct 19, 2017


No no no. Time to remove it and put it back in dev deps. People should get their assertion module explicitly.

@hueniverse hueniverse merged commit d002e75 into hapijs:master Oct 23, 2017
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
continuous-integration/travis-ci/pr The Travis CI build passed
@geek geek deleted the geek:async branch Oct 23, 2017
hueniverse added a commit that referenced this pull request Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.