Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript typings #797

Merged
merged 1 commit into from Dec 9, 2017

Conversation

@corbinu
Copy link
Contributor

corbinu commented Dec 9, 2017

I merged in my typings and updated for the new use of async/await.

I also removed the Expect typings. They can be added back in however given that other assertion libraries can be used I think there are two better options:

  1. Currently I simply import expect from code separately and then use the @typings/code package. I have some enhancements I can simply commit to there.
  2. We could merge typings into code as well and import those.

Would love to get peoples thoughts on which is better

@geek

This comment has been minimized.

Copy link
Member

geek commented Dec 9, 2017

@corbinu I'd vote for 2 to get the code typings in.

@geek geek added the lts label Dec 9, 2017
@geek geek self-assigned this Dec 9, 2017
@geek geek added this to the 15.1.3 milestone Dec 9, 2017
@geek geek merged commit d971304 into hapijs:master Dec 9, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Node Security No known vulnerabilities found
Details
@corbinu corbinu mentioned this pull request Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.