Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add URL and URLSearchParams to global variables #808

Merged
merged 1 commit into from Feb 9, 2018

Conversation

@mcollina
Copy link
Contributor

mcollina commented Feb 9, 2018

Those will be globals in Node 10 (and current are in node master).
I'm sending this PR early because shot is currently failing on CITGM.

Ref hapijs/shot#91.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Feb 9, 2018

Should probably be added like in L92-115.

@mcollina mcollina force-pushed the mcollina:fix-node-10 branch from 2b9cbfd to a3fe4bb Feb 9, 2018
@mcollina

This comment has been minimized.

Copy link
Contributor Author

mcollina commented Feb 9, 2018

Done.

@mcollina

This comment has been minimized.

Copy link
Contributor Author

mcollina commented Feb 9, 2018

I do not know why that test is failing (see https://travis-ci.org/hapijs/lab/jobs/339389589), I think that test is flaky.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Feb 9, 2018

Can't get a flake locally but apparently travis can indeed.

@geek geek self-assigned this Feb 9, 2018
@geek geek added the lts label Feb 9, 2018
@geek geek added this to the 15.2.2 milestone Feb 9, 2018
@geek geek merged commit 617f442 into hapijs:master Feb 9, 2018
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek

This comment has been minimized.

Copy link
Member

geek commented Feb 9, 2018

Thanks for the help @mcollina

@mcollina mcollina deleted the mcollina:fix-node-10 branch Feb 9, 2018
@mcollina

This comment has been minimized.

Copy link
Contributor Author

mcollina commented Feb 9, 2018

No worries, I'm trying to get CITGM greener, and this was on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.