Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write CLI errors to stderr #810

Merged
merged 1 commit into from Feb 9, 2018

Conversation

@geek
Copy link
Member

geek commented Feb 9, 2018

Fixes #399

@geek geek added the bug label Feb 9, 2018
@geek geek added this to the 15.2.2 milestone Feb 9, 2018
@geek geek self-assigned this Feb 9, 2018
@geek geek requested a review from cjihrig Feb 9, 2018
lib/cli.js Outdated
@@ -112,12 +112,12 @@ internals.traverse = function (paths, options) {
if (err.code !== 'ENOENT') {
throw err;
}
options.output.write('Could not find test file or directory \'' + nextPath + '\'.\n');
console.error('Could not find test file or directory \'' + nextPath + '\'.\n');

This comment has been minimized.

Copy link
@cjihrig

cjihrig Feb 9, 2018

Contributor

Won't there be extra line breaks after moving to console.error()?

@geek geek force-pushed the geek:399 branch from 0b4c98f to ec36283 Feb 9, 2018
@geek geek force-pushed the geek:399 branch from ec36283 to 574c1e1 Feb 9, 2018
@cjihrig
cjihrig approved these changes Feb 9, 2018
@geek geek merged commit 2e60ba8 into hapijs:master Feb 9, 2018
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek geek deleted the geek:399 branch Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.