Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minimum assertions threshold. Closes #690. #819

Merged
merged 1 commit into from Mar 12, 2018

Conversation

@Marsup
Copy link
Member

Marsup commented Mar 12, 2018

For some reason I couldn't enable it for lab itself as a few tests failed, probably something to do with lab testing lab...

@Marsup Marsup added the feature label Mar 12, 2018
@Marsup Marsup requested a review from geek Mar 12, 2018
@geek geek added this to the 15.4.0 milestone Mar 12, 2018
@geek geek self-assigned this Mar 12, 2018
@geek

This comment has been minimized.

Copy link
Member

geek commented Mar 12, 2018

Thanks, @Marsup... this will be nice to have to enable at least 1 assertion for every test. Maybe when we do v16 we can default the min-threshold to 1.

@geek geek merged commit d043fb0 into master Mar 12, 2018
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the min-asserts branch Mar 12, 2018
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented Mar 12, 2018

I don't know, it's good as an option as well, not everyone is using code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.