Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore default-plan-threshold for anything else than tests #820

Merged
merged 1 commit into from Mar 20, 2018

Conversation

@Marsup
Copy link
Member

Marsup commented Mar 20, 2018

Follow-up to #819.

I don't think the default assertion threshold should apply to befores and afters, I didn't notice it in the initial PR but I don't think this part makes sense after using it. Would you agree ?

@Marsup Marsup added the bug label Mar 20, 2018
@Marsup Marsup requested a review from geek Mar 20, 2018
@geek geek added this to the 15.4.1 milestone Mar 20, 2018
@geek

This comment has been minimized.

Copy link
Member

geek commented Mar 20, 2018

@Marsup absolutely agree. I'm going to keep this as 15.4.1 since the previous enhancement release is still new.

@geek geek self-assigned this Mar 20, 2018
@geek geek merged commit 27dcdc8 into master Mar 20, 2018
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the plan-threshold-for-tests branch Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.