Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for stdout to stop writing to exit #829

Merged
merged 1 commit into from May 7, 2018
Merged

Wait for stdout to stop writing to exit #829

merged 1 commit into from May 7, 2018

Conversation

@Marsup
Copy link
Member

Marsup commented Apr 28, 2018

Naive approach to prevent lab from exiting prematurely. It watches stdout until it stops emitting things. 5 seems to be a sweet spot but I guess it could be system dependent.

@Marsup Marsup added the bug label Apr 28, 2018
@geek geek self-assigned this May 7, 2018
@geek geek added this to the 15.4.3 milestone May 7, 2018
@geek
geek approved these changes May 7, 2018
@geek geek merged commit f5a2fc8 into master May 7, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek geek deleted the wait-for-stdout-end branch May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.