Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage ECMA version to 9 (2018). #836

Merged
merged 1 commit into from Jun 1, 2018

Conversation

@mathewdgardner
Copy link
Contributor

mathewdgardner commented May 17, 2018

Close if wrong approach but with Node 10 we now have async iterators / generators. While I can have eslint use ecma 2018, running lab with coverage without this change pukes with SyntaxError: Unexpected token await errors.

@@ -270,7 +270,7 @@ internals.instrument = function (filename) {
ecmaFeatures: {

This comment has been minimized.

Copy link
@devinivy

devinivy May 17, 2018

Member

It's worth verifying, but I think this ecmaFeatures config can go away if we bump the ecmaVersion to 9.

This comment has been minimized.

Copy link
@mathewdgardner

mathewdgardner May 17, 2018

Author Contributor

It looks like the option is removed in espree v4.0.0.alpha.0 eslint/espree#374

@geek

This comment has been minimized.

Copy link
Member

geek commented May 17, 2018

I'll verify if this will break anything and then merge. Thanks for the update.

@geek geek added the feature label Jun 1, 2018
@geek geek self-assigned this Jun 1, 2018
@geek geek added this to the 15.4.6 milestone Jun 1, 2018
@geek geek merged commit dd700e3 into hapijs:master Jun 1, 2018
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.