Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve console coverage report readability #871

Merged
merged 4 commits into from Nov 1, 2018

Conversation

@mkantor
Copy link
Contributor

mkantor commented Oct 30, 2018

The way coverage reports were presented in the console made them hard to skim. I made a few tweaks to try and improve this:

  • Report runs of contiguous lines as ranges (e.g. "7-11") instead of listing every line number.
  • Truncate coverage reports when they get too long.
  • Color the detail portion yellow instead of red.

Before:

screen shot 2018-10-30 at 3 36 28 pm

After:

screen shot 2018-10-30 at 3 38 46 pm

Let me know what you think!

@mkantor mkantor force-pushed the mkantor:improve-console-coverage-report branch from 5bbcf0f to 1f459f6 Nov 1, 2018
@geek geek self-assigned this Nov 1, 2018
@geek geek added the feature label Nov 1, 2018
@geek geek added this to the 17.1.0 milestone Nov 1, 2018
@geek geek merged commit 54f841c into hapijs:master Nov 1, 2018
1 of 2 checks passed
1 of 2 checks passed
Node Security nsp check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek

This comment has been minimized.

Copy link
Member

geek commented Nov 1, 2018

@mkantor I really like the range and color changes. However, I don't want to truncate the output at 8 lines or really at any number of lines at this time. I'm going to revert the truncation.

@mkantor

This comment has been minimized.

Copy link
Contributor Author

mkantor commented Nov 1, 2018

Thanks for merging!

@mkantor mkantor deleted the mkantor:improve-console-coverage-report branch Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.