Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --coverage-all option #877

Merged
merged 5 commits into from Nov 2, 2018

Conversation

@aimee-gm
Copy link
Contributor

aimee-gm commented Nov 2, 2018

Fixes #710

  • Adds option to specify --coverage-all flag.
  • Reports coverage for all files that match --coverage-path, regardless of a test touching them
  • Respects --coverage-exclude
  • Adds --coverage-flat to prevent recursive finding of files for coverage

One outstanding issue, which I am currently unsure how to resolve:

Coverage: 99.96% (1/2254)
lib/coverage.js missing coverage on line(s): 412
Code coverage below threshold: 99.96 < 100

which refers to: if (stat.isFile() && Path.basename(nextPath)[0] !== '.') { 🤷‍♀️

Feedback on the changes welcome and a suggestion of how to hit the code coverage would be helpful 👍

lib/cli.js Show resolved Hide resolved
lib/coverage.js Show resolved Hide resolved
@geek geek added the feature label Nov 2, 2018
@geek geek self-assigned this Nov 2, 2018
@geek
geek approved these changes Nov 2, 2018
@geek geek added this to the 17.2.0 milestone Nov 2, 2018
@geek geek merged commit c194b84 into hapijs:master Nov 2, 2018
1 of 2 checks passed
1 of 2 checks passed
Node Security nsp check
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.