Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated double call check on done to provide error to internals.output #88

Merged
merged 1 commit into from May 1, 2014

Conversation

@jasonpincin
Copy link
Contributor

jasonpincin commented May 1, 2014

When done was called twice inside of a test, undefined was being printed twice to stderr because internals.output expects an error object and the condition checking for done being called twice was providing a string. Thus, the tester has no idea. Ask me how I know...

I also added an extra carriage return at end of internals.output which keeps output clean when running tests in an automated tool such as nodemon.

Fixes #87

…n done to provide such
@hueniverse hueniverse added the bug label May 1, 2014
@hueniverse hueniverse added this to the 3.2.0 milestone May 1, 2014
@hueniverse hueniverse self-assigned this May 1, 2014
hueniverse added a commit that referenced this pull request May 1, 2014
updated double call check on done to provide error to internals.output
@hueniverse hueniverse merged commit 5d7c876 into hapijs:master May 1, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.