Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing coverage and remove unnecessary checks #882

merged 4 commits into from Nov 7, 2018


Copy link

geek commented Nov 7, 2018

Adds missing coverage discovered from #878

geek added 4 commits Nov 4, 2018
@geek geek added this to the 18.0.0 milestone Nov 7, 2018
@@ -354,7 +354,7 @@ internals.Reporter.prototype.end = function (notebook) {

if (coverage.percent < this.settings.threshold || isNaN(coverage.percent)) {

This comment has been minimized.

Copy link

geek Nov 7, 2018

Author Member

NaN cannot make it into this branch because of the conditional check above coverage.percent < 100

@geek geek added the test label Nov 7, 2018
@geek geek requested a review from hueniverse Nov 7, 2018
@hueniverse hueniverse merged commit 1e5a483 into hapijs:master Nov 7, 2018
2 checks passed
2 checks passed
Node Security No known vulnerabilities found
continuous-integration/travis-ci/pr The Travis CI build passed
@geek geek deleted the geek:cov branch Nov 7, 2018
@geek geek self-assigned this Nov 7, 2018
@@ -170,8 +170,7 @@ exports.detect = function (customGlobals) {
const leaks = [];
const globals = Object.getOwnPropertyNames(global);
for (let i = 0; i < globals.length; ++i) {
if (!whitelist[globals[i]] &&
global[globals[i]] !== global) {
if (!whitelist[globals[i]]) {

This comment has been minimized.

Copy link

hueniverse Nov 7, 2018


No need for the extra new lines...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.