Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage file filter function modified to support Windows paths #32 #91

Merged
merged 1 commit into from May 19, 2014

Conversation

@paed01
Copy link
Contributor

paed01 commented May 10, 2014

Hope this also vorks for non-windows environments.

@paed01

This comment has been minimized.

Copy link
Contributor Author

paed01 commented May 15, 2014

I've tested the PR on raspbian running npm test on catbox. Output with some extra console.log:

> catbox@2.2.1 test /home/pi/tmp/catbox
> make test-cov

----8<---- extra console.log
lab/coverage#instrument /home/pi/tmp/catbox/index.js
lab/coverage#instrument /home/pi/tmp/catbox/lib/index.js
lab/coverage#instrument /home/pi/tmp/catbox/lib/client.js
lab/coverage#instrument /home/pi/tmp/catbox/lib/policy.js
---->8----

  ..................................................
  ........................................

 90 tests complete (1418 ms)

 No global variable leaks detected.

 Coverage: 99.68%

 lib/policy.js missing coverage on line(s): 143
 Code coverage below threshold: 99.68 < 100

make: *** [test-cov] Error 1
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
hueniverse added a commit that referenced this pull request May 19, 2014
Coverage file filter function modified to support Windows paths #32
@hueniverse hueniverse merged commit adcd810 into hapijs:master May 19, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@hueniverse hueniverse added the bug label May 19, 2014
@hueniverse hueniverse added this to the 3.2.0 milestone May 19, 2014
@hueniverse hueniverse self-assigned this May 19, 2014
hueniverse added a commit that referenced this pull request May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.