Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple "only" flags #923

Merged
merged 4 commits into from Jun 14, 2019
Merged

Support multiple "only" flags #923

merged 4 commits into from Jun 14, 2019

Conversation

@tpburch
Copy link

tpburch commented May 23, 2019

Multiple "only" flags currently work, but only in certain cases
depending on experimnet depth. This PR implements full support for
multiple "only" flags, regardless of same experiment, different
experimnt, different script, and depth.

As an approach, prior to marking non-only tests as skipped, we now mark
all parents of an "only" element as "only" (unless they are explicitly
skipped).

Also, fixed a few incorrect tests.

Tim Burch
Multiple "only" flags currently work, but only in certain cases
depending on experimnet depth. This PR implements full support for
multiple "only" flags, regardless of same experiment, different
experimnt, different script, and depth.

As an approach, prior to marking non-only tests as skipped, we now mark
all parents of an "only" element as "only" (unless they are explicitly
skipped).

Also, fixed a few incorrect tests.
Tim Burch added 2 commits May 23, 2019
lib/runner.js Show resolved Hide resolved
lib/runner.js Show resolved Hide resolved
@geek geek added the bug label May 23, 2019
@geek geek added this to the 19.0.2 milestone May 23, 2019
@geek
geek approved these changes May 23, 2019
@tpburch

This comment has been minimized.

Copy link
Author

tpburch commented May 30, 2019

@geek @hueniverse Is there any action I need to take before this can be merged?

@geek

This comment has been minimized.

Copy link
Member

geek commented Jun 6, 2019

@tpburch I don't think there is any other changes you need to make. I need @hueniverse to merge/publish as I don't have permissions to publish.

@geek geek merged commit 36e6a3a into hapijs:master Jun 14, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.