Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required callback to subscription onSubscribe option #100

Closed
hueniverse opened this issue Mar 2, 2016 · 0 comments
Assignees
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Mar 2, 2016

When a subscription specifies the onSubscribe option, that callback method now includes a 4th argument called next which must be called in order to complete the subscription request. It takes an optional err argument which if set, fails the subscription request and passes the error back to the client.

Failing to call next() will result in a subscription request timeout.

@hueniverse hueniverse self-assigned this Mar 2, 2016
@hueniverse hueniverse added this to the 3.1.3 milestone Mar 2, 2016
@hueniverse hueniverse closed this in fb1dd6f Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.