Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clean up sockets and subscriptions on server stop #121

Closed
hueniverse opened this issue May 5, 2016 · 0 comments
Closed

Properly clean up sockets and subscriptions on server stop #121

hueniverse opened this issue May 5, 2016 · 0 comments
Assignees
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented May 5, 2016

  • client.unsubscribe() - now has a third argument callback and the second argument is required (pass null explicitly to remove all handlers).
  • Subscription onUnsubscribe options callback has a new 4th required argument next that must be called to complete the unsubscribe request.
@hueniverse hueniverse self-assigned this May 5, 2016
@hueniverse hueniverse added the bug label May 5, 2016
@hueniverse hueniverse added this to the 4.6.1 milestone May 5, 2016
@hueniverse hueniverse closed this in 3c2b81f May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.