Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect fails to check for previous internal socket when connecting. #125

Closed
tkh44 opened this issue May 12, 2016 · 1 comment
Assignees
Milestone

Comments

@tkh44
Copy link
Contributor

@tkh44 tkh44 commented May 12, 2016

If you call connect() before calling disconnect the previous this._ws is not properly cleaned up.

You can see this._ws being set here with no check.

this._ws = ws;

@hueniverse hueniverse added the bug label May 12, 2016
@hueniverse hueniverse added this to the 5.0.4 milestone May 12, 2016
@hueniverse hueniverse self-assigned this May 12, 2016
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented May 12, 2016

This is marked as breaking change because it changes the internal timings of callbacks and notifications. You should test your application before upgrading to ensure you do not currently rely on specific timings (order of on___ events and function callbacks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.