Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined payloads from server in client #156

Closed
davidjamesstone opened this issue Sep 18, 2016 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@davidjamesstone
Copy link

@davidjamesstone davidjamesstone commented Sep 18, 2016

NesError(error, type) can be called with the error argument undefined.

This can happen if update.payload.message || update.payload.error are both undefined here:

https://github.com/davidjamesstone/nes/blob/master/lib/client.js#L616

This guards against it

@hueniverse hueniverse self-assigned this Mar 20, 2017
@hueniverse hueniverse added the bug label Mar 20, 2017
@hueniverse hueniverse added this to the 6.4.2 milestone Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.