Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`maximum call stack exceeded` if web socket gets disconnected while nes is sending packets #179

Closed
iantocristian opened this issue Jun 15, 2017 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@iantocristian
Copy link

@iantocristian iantocristian commented Jun 15, 2017

https://github.com/hapijs/nes/blob/master/lib/socket.js#L181 ws.send calls back synchronously with socket not opened error, flush is called again and will try to send the next packet, and so on. There have to be enough packets in the queue at the time of the disconnect to trigger the call stack exceeded error.

@hueniverse hueniverse self-assigned this Jul 18, 2017
@hueniverse hueniverse added the bug label Jul 18, 2017
@hueniverse hueniverse added this to the 6.4.3 milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.