Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUnknown authentication strategy #285
Comments
This comment has been minimized.
This comment has been minimized.
Why are you setting auth mode on the authentication endpoint?! I am aware it is possible but I don't understand the use case. The auth endpoint is used only for auth. There is no purpose to it other than that. If you want to set optional auth, you do that on the actual endpoints nes is serving. Am I missing something? |
This comment has been minimized.
This comment has been minimized.
@hueniverse my use case is the following: any user should be able to connect in order to receive updates but once a user signs in he will reauthenticate and receive personal updates. |
This comment has been minimized.
This comment has been minimized.
That doesn't mean you want the authentication endpoint to have optional authentication. If you simply omit auth from the connection, you will have optional authentication. |
If we set the mode to
optional
, the very first auth reverification after the initial connection will fail:I tracked it down and these line cause the issues:
this._strategies
contains my defined strategies butauth.strategy
is empty and thus it fails.This is my code for Nes in general: