Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message metadata for publish #63

Closed
kpdecker opened this issue Oct 20, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Oct 20, 2015

Add the ability to include metadata to a particular message that is passed to the filter method, but is not sent to the final consumer.

This may be used, for example, to prevent sending a message to the session that generated the message in the first place.

@kpdecker

This comment has been minimized.

Copy link
Contributor Author

@kpdecker kpdecker commented Oct 20, 2015

Strawman:

server.publish(path, message, {metadata});
filter(path, message, {credentials, params, metadata}, next)
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Oct 21, 2015

Seems ok. Why not call it options?

@kpdecker

This comment has been minimized.

Copy link
Contributor Author

@kpdecker kpdecker commented Oct 21, 2015

Was trying to leave room for other functionality in the future, for publish, this is actually an options argument with a metadata field.

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Oct 21, 2015

I don't like the name metadata. How about internal?

@hueniverse hueniverse added the request label Oct 21, 2015
@kpdecker

This comment has been minimized.

Copy link
Contributor Author

@kpdecker kpdecker commented Oct 21, 2015

Sure.

kpdecker added a commit that referenced this issue Oct 21, 2015
Fixes #63
@hueniverse hueniverse added this to the 1.1.0 milestone Oct 21, 2015
@Marsup Marsup added feature and removed request labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.