Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UMD global handling #108

Merged
merged 1 commit into from Mar 30, 2016

Conversation

@kpdecker
Copy link
Contributor

kpdecker commented Mar 30, 2016

Babel replaces this with undefined under strict mode, breaking the global declaration for the UMD module. Unclear on if this changed recently (I doubt) or if we never tested this under globals mode before.

Fixes #105

Babel replaces this with undefined under strict mode, breaking the global declaration for the UMD module. Unclear on if this changed recently (I doubt) or if we never tested this under globals mode before.

Fixes #105
@kpdecker kpdecker force-pushed the umd-strict-fix branch from 5fe4003 to fe0fdde Mar 30, 2016
@hueniverse hueniverse added the bug label Mar 30, 2016
@hueniverse hueniverse added this to the 4.2.1 milestone Mar 30, 2016
@hueniverse hueniverse self-assigned this Mar 30, 2016
@hueniverse hueniverse merged commit f9d8213 into master Mar 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hueniverse hueniverse deleted the umd-strict-fix branch Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.