Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace message for all sockets with override from filter #214

Merged
merged 1 commit into from Feb 28, 2018

Conversation

@mtharrison
Copy link
Member

mtharrison commented Feb 4, 2018

This ensures that an override message does not affect the message sent to other connected sockets. First though it would be great if @hueniverse can confirm this is indeed a bug and not a feature.

Closes #212

@mtharrison mtharrison added the bug label Feb 4, 2018
@mtharrison mtharrison changed the title Do not replace message with override Do not replace message for all sockets with override from filter Feb 4, 2018
@mtharrison

This comment has been minimized.

Copy link
Member Author

mtharrison commented Feb 25, 2018

I'll wait another day to see if anyone wants to give feedback on this, otherwise I'll merge it tomorrow.

@mtharrison mtharrison merged commit 6f957ea into master Feb 28, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mtharrison mtharrison deleted the fix-issue-212 branch Feb 28, 2018
@mtharrison mtharrison added this to the 7.0.3 milestone Feb 28, 2018
@mtharrison mtharrison self-assigned this Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.