Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws to 5.x.x #229

Merged
merged 2 commits into from Mar 20, 2018
Merged

Update ws to 5.x.x #229

merged 2 commits into from Mar 20, 2018

Conversation

@mtharrison
Copy link
Member

mtharrison commented Mar 20, 2018

https://github.com/websockets/ws/releases

  • Removed code that handles net.Socket errors after open. ws no longer emits these.

Although there seems to be no breaking changes in the nes API, I think a major version for this is wise because we're upgrading 2 major versions ahead of a core library. Nes allows raw options to be passed straight to ws too and some of those options have changed according to the release notes.

Closes #211

mtharrison added 2 commits Mar 20, 2018
@mtharrison mtharrison self-assigned this Mar 20, 2018
@mtharrison mtharrison added this to the 8.0.0 milestone Mar 20, 2018
@mtharrison mtharrison merged commit 14fe725 into master Mar 20, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mtharrison mtharrison deleted the update-ws-5 branch Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.