Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect on error #247

Merged
merged 1 commit into from Jul 2, 2018
Merged

Reconnect on error #247

merged 1 commit into from Jul 2, 2018

Conversation

@lpww
Copy link
Contributor

lpww commented Jun 25, 2018

Attempt to reconnect on a websocket error, as recommended in #242

@lpww lpww force-pushed the lpww:reconnect-on-error branch from 62888f0 to 982fd81 Jun 25, 2018
@mtharrison

This comment has been minimized.

Copy link
Member

mtharrison commented Jul 2, 2018

Having testing, it all seems to do what it's supposed to. I've run some IE11 tests in Browserstack too and can confirm that it will reconnect when server restarts unlike before.

@mtharrison mtharrison added the bug label Jul 2, 2018
@mtharrison mtharrison self-assigned this Jul 2, 2018
@mtharrison mtharrison merged commit 2da53bf into hapijs:master Jul 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mtharrison mtharrison added this to the 9.0.1 milestone Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.