Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minAuthVerifyInterval and make it less restrictive #263

Merged
merged 2 commits into from Nov 24, 2018

Conversation

@dominykas
Copy link
Contributor

dominykas commented Nov 23, 2018

  • Changed the default minAuthVerifyInterval value to be the same as configured heartbeat.interval, rather than the hardcoded 15s - otherwise when heartbeat.interval is configured to be longer than that, this becomes a breaking change.
  • When heartbeat is disabled, no throttling applies (not sure how people use it, but this might mean that after all - _verifyAuth() should be called on outgoing messages too).
dominykas added 2 commits Nov 23, 2018
@hueniverse hueniverse merged commit 246338f into hapijs:master Nov 24, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse self-assigned this Nov 24, 2018
@hueniverse hueniverse added the feature label Nov 24, 2018
@hueniverse hueniverse added this to the 9.1.0 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.