Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eachSocket iterator #62

Merged
merged 2 commits into from Oct 21, 2015
Merged

Implement eachSocket iterator #62

merged 2 commits into from Oct 21, 2015

Conversation

@kpdecker
Copy link
Contributor

kpdecker commented Oct 19, 2015

Provides a formal API for consumers to interact with currently connected clients.

Fixes #48

API.md Outdated

Iterates over all connected sockets, optionally filtering on those that have subscribed to
a given subscription. This operation is synchronous.
- `callback` - Iteration callback in the form `function(socket)`.

This comment has been minimized.

Copy link
@hueniverse

hueniverse Oct 19, 2015

Member

Call this each or something other than callback.

This comment has been minimized.

Copy link
@kpdecker

kpdecker Oct 19, 2015

Author Contributor

What is the concern here? This matches the Array.forEach spec.

This comment has been minimized.

Copy link
@hueniverse

hueniverse Oct 21, 2015

Member

But not the hapi style guide. callback and next have specific meanings, and are always only called once.

API.md Outdated
a given subscription. This operation is synchronous.
- `callback` - Iteration callback in the form `function(socket)`.
- `options` - Optional options object
- `subscription` - Limit to sockets that are subscribed to a given path.

This comment has been minimized.

Copy link
@hueniverse

hueniverse Oct 19, 2015

Member

Should be more specific: when set to a string path...

Provides a formal API for consumers to interact with currently connected clients.

Fixes #48
@kpdecker kpdecker force-pushed the each-socket branch from 8b7e7ad to a0c80a9 Oct 20, 2015
@kpdecker

This comment has been minimized.

Copy link
Contributor Author

kpdecker commented Oct 20, 2015

Updated the other two items and pushed.

hueniverse added a commit that referenced this pull request Oct 21, 2015
Implement eachSocket iterator
@hueniverse hueniverse merged commit 451430a into master Oct 21, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hueniverse hueniverse added the feature label Oct 21, 2015
@hueniverse hueniverse self-assigned this Oct 21, 2015
@hueniverse hueniverse added this to the 1.1.0 milestone Oct 21, 2015
@hueniverse hueniverse deleted the each-socket branch Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.