Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hoek and dev dependencies #19

Merged
merged 2 commits into from Feb 11, 2019

Conversation

@momiller121
Copy link
Contributor

momiller121 commented Feb 5, 2019

dependency, maintenance

I wanted to address the hoek@5.0.4 deprecation warning. Also updated the dev dependencies.

I'd appreciate a second set of eyes on the small change I made to the failing test on the 2.0.0 release. It gives me pause to 'fix' a test by changing the assertion... (It's interesting that this passed for the TravisCI build at 2.0.0. release time - maybe a hapi change in the interim?).

I don't have much experience with submitting a pull request. Feel free to advise or let me know how to contribute more effectively.

momiller121 added 2 commits Feb 5, 2019
This test was failing on the 2.0.0 release. On looking into it,
it seems that the 200 in the assertion is incorrect because we
are looking for the disconnect in this case.
@bableharry

This comment has been minimized.

Copy link

bableharry commented Feb 11, 2019

Great

@@ -312,7 +312,7 @@ describe('Oppsy', () => {
total: 1,
disconnects: 1,
statusCodes: {
'200': 1
'499': 1

This comment has been minimized.

Copy link
@arb

arb Feb 11, 2019

Contributor

Why this change? Oh I see we bumped the version of hapi as well.

@arb arb added this to the 2.0.1 milestone Feb 11, 2019
@hueniverse hueniverse merged commit e4057ef into hapijs:master Feb 11, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.