Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor global scope only logic #2

Merged
merged 1 commit into from Dec 29, 2015
Merged

refactor global scope only logic #2

merged 1 commit into from Dec 29, 2015

Conversation

@cjihrig
Copy link
Collaborator

cjihrig commented Dec 29, 2015

The existing logic that determined if a require() was at the top level scope broke between ESLint v1.3.1 and v1.4.0 (likely eslint/eslint#3700). This PR refactors that logic, using ESLint's global-require rule as a template.

@cjihrig cjihrig added the bug label Dec 29, 2015
@cjihrig cjihrig self-assigned this Dec 29, 2015
@cjihrig cjihrig added this to the v1.1.4 milestone Dec 29, 2015
cjihrig added a commit that referenced this pull request Dec 29, 2015
refactor global scope only logic
@cjihrig cjihrig merged commit a34ac03 into hapijs:master Dec 29, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cjihrig cjihrig deleted the cjihrig:update branch Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.