Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node V12 deprecation warning [DEP0066] OutgoingMessage.prototype._headers is deprecated #108

Closed
yonjah opened this issue May 7, 2019 · 2 comments · Fixed by #109
Closed

Node V12 deprecation warning [DEP0066] OutgoingMessage.prototype._headers is deprecated #108

yonjah opened this issue May 7, 2019 · 2 comments · Fixed by #109
Assignees
Labels
Milestone

Comments

@yonjah
Copy link

@yonjah yonjah commented May 7, 2019

When using latest hapi (v18.3.1) and shot (v4.1.0) with Node V12 a deprecation warning is thrown from response.js:18 -

(node:32073) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
    at new module.exports.internals.Response (node_modules/@hapi/shot/lib/response.js:18:23)
    at node_modules/@hapi/shot/lib/index.js:58:21
@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented May 19, 2019

Will take a bit to get to all these in the org.

@SimonSchick

This comment has been minimized.

Copy link

@SimonSchick SimonSchick commented May 25, 2019

@hueniverse would version detection ala process.version.startsWith('v8.') be an acceptable solution here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.