Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated assignment #12

Closed
wants to merge 1 commit into from
Closed

Conversation

@bnjmnt4n
Copy link

bnjmnt4n commented May 31, 2014

No description provided.

@bnjmnt4n

This comment has been minimized.

Copy link
Author

bnjmnt4n commented Jun 4, 2014

Ping? :)

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 4, 2014

This is tricky. It is needed in older versions of hapi and node. I need to test against a bunch first.

@bnjmnt4n

This comment has been minimized.

Copy link
Author

bnjmnt4n commented Jun 6, 2014

Why is that section needed twice? It is already defined above.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 7, 2014

One is Request and the other Response.

@hueniverse hueniverse closed this Jun 14, 2014
@hueniverse hueniverse self-assigned this Jun 14, 2014
@bnjmnt4n

This comment has been minimized.

Copy link
Author

bnjmnt4n commented Jun 15, 2014

Request is defined here. Response is defined here, but is redefined here, which is what this PR removes.

@bnjmnt4n

This comment has been minimized.

Copy link
Author

bnjmnt4n commented Jul 16, 2014

ping @hueniverse can you relook this?

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Aug 2, 2014

You are correct.

@hueniverse hueniverse added bug and removed non-issue labels Aug 2, 2014
@hueniverse hueniverse added this to the 1.4.0 milestone Aug 2, 2014
hueniverse added a commit that referenced this pull request Aug 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.