Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -L to test and test-cov #27

Closed
wants to merge 2 commits into from
Closed

Conversation

@johnbrett
Copy link
Contributor

johnbrett commented Mar 3, 2015

Adding -L to all Makefile options as mentioned in #21

johnbrett added 2 commits Mar 3, 2015
@johnbrett

This comment has been minimized.

Copy link
Contributor Author

johnbrett commented Mar 4, 2015

Replaced Makefile with npm scripts also #21 (comment) Thanks @AdriVanHoudt @lloydbenson

@AdriVanHoudt

This comment has been minimized.

Copy link

AdriVanHoudt commented Mar 4, 2015

LGTM

@AdriVanHoudt

This comment has been minimized.

Copy link

AdriVanHoudt commented Mar 4, 2015

This with #25 closes #21 right?

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Mar 5, 2015

@arb can you review and merge?

@chrisdickinson chrisdickinson added this to the 1.4.2 milestone Mar 5, 2015
"test": "make test-cov"
"test": "node_modules/lab/bin/lab -a code -L",
"test-cov": "node_modules/lab/bin/lab -a code -t 100 -L",
"test-cov-html": "node_modules/lab/bin/lab -a code -r html -o coverage.html -L"

This comment has been minimized.

Copy link
@chrisdickinson

chrisdickinson Mar 5, 2015

Contributor

it should be unnecessary to add node_modules/lab/bin/ here – node_modules/.bin/ is automatically on path.

This comment has been minimized.

Copy link
@chrisdickinson

chrisdickinson Mar 5, 2015

Contributor

will fix this in merge.

@chrisdickinson

This comment has been minimized.

Copy link
Contributor

chrisdickinson commented Mar 5, 2015

Merged in d30209e, published to npm as v1.4.2.

@lloydbenson

This comment has been minimized.

Copy link
Contributor

lloydbenson commented Mar 5, 2015

Thanks Chris!

On Thu, Mar 5, 2015 at 4:45 PM, Chris Dickinson notifications@github.com
wrote:

Merged in d30209e
d30209e,
published to npm as v1.4.2.


Reply to this email directly or view it on GitHub
#27 (comment).

@hueniverse hueniverse assigned chrisdickinson and unassigned arb Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.