Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7 #30

Merged
merged 3 commits into from Jun 4, 2015
Merged

fix #7 #30

merged 3 commits into from Jun 4, 2015

Conversation

@iamdoron
Copy link
Contributor

iamdoron commented May 22, 2015

No description provided.

iamdoron added 2 commits May 22, 2015
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented May 22, 2015

Can't use the buffer-equal module because it's not 1.x.x or later. Just copy/paste that function into shot and add a comment above it with where it was copied from and the license its under (MIT).

@iamdoron

This comment has been minimized.

Copy link
Contributor Author

iamdoron commented May 22, 2015

OK
I created a new .js file for it and cleaned it up to comply with the linter

@hueniverse hueniverse added the bug label Jun 4, 2015
@hueniverse hueniverse added this to the 1.5.1 milestone Jun 4, 2015
@hueniverse hueniverse self-assigned this Jun 4, 2015
hueniverse added a commit that referenced this pull request Jun 4, 2015
fix #7
@hueniverse hueniverse merged commit 07255e2 into hapijs:master Jun 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Jun 4, 2015

Project was set wrong so coverage wasn't checked. I'll have to fix coverage now... :-/ You really don't need most of the buffer equal method.

hueniverse added a commit that referenced this pull request Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.