Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rawPayload, convert to UTF8 after the whole buffer is available #32

Merged
merged 2 commits into from Jun 5, 2015

Conversation

@iamdoron
Copy link
Contributor

iamdoron commented Jun 4, 2015

I accidentally changed the name of rawPayload, that's should comply with hapi api docs. I also moved the UTF8 conversion to the end, it could, result in an improper UTF8 string conversion. I added the 'utf8' to be super clear about the conversion.

@iamdoron

This comment has been minimized.

Copy link
Contributor Author

iamdoron commented Jun 4, 2015

I added to the PR another fix, I updated the PR details

@iamdoron iamdoron changed the title use rawPayload use rawPayload, convert to UTF8 after the whole buffer is available Jun 4, 2015
@hueniverse hueniverse added the bug label Jun 5, 2015
@hueniverse hueniverse added this to the 1.5.2 milestone Jun 5, 2015
@hueniverse hueniverse self-assigned this Jun 5, 2015
hueniverse added a commit that referenced this pull request Jun 5, 2015
use rawPayload, convert to UTF8 after the whole buffer is available
@hueniverse hueniverse merged commit 4a7a728 into hapijs:master Jun 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.