Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stream payloads #67

Merged
merged 2 commits into from May 24, 2016
Merged

Support stream payloads #67

merged 2 commits into from May 24, 2016

Conversation

@mtharrison
Copy link
Member

mtharrison commented Apr 13, 2016

Closes #53

@ruiquelhas

This comment has been minimized.

Copy link

ruiquelhas commented May 20, 2016

Any estimate for this to get merged? Do you need help with it?

@@ -91,6 +93,26 @@ exports = module.exports = internals.Request = function (options) {
Util.inherits(internals.Request, Stream.Readable);


internals.Request.prototype.prepare = function (next) {

if (!(this._shot.payload instanceof Stream)) {

This comment has been minimized.

Copy link
@hueniverse

hueniverse May 20, 2016

Member

I prefer === false than double ()

This comment has been minimized.

Copy link
@mtharrison

mtharrison May 24, 2016

Author Member

Good call. Fixed.

@mtharrison mtharrison force-pushed the mtharrison:stream-payload branch from d5d8b2b to 89ba5ad May 24, 2016
@hueniverse hueniverse merged commit 0122a2c into hapijs:master May 24, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse self-assigned this May 24, 2016
@hueniverse hueniverse added this to the 3.0.2 milestone May 24, 2016
@mtharrison mtharrison deleted the mtharrison:stream-payload branch May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.