Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle streams of utf8 encoded strings #81

Merged
merged 1 commit into from Sep 9, 2016
Merged

Conversation

@mtharrison
Copy link
Member

mtharrison commented Sep 9, 2016

This allows you to pass shot a stream that's in utf8 encoding mode, that is a stream of strings - such as the https://github.com/form-data/form-data library provides.

This breaks compatibility with Node < 4.5.0 because of the use of Buffer.from(string).

Closes #77

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 9, 2016

We only support node 4 latest as a policy so it is not a breaking change from that alone. We usually leave the label but publish as a minor.

@mtharrison mtharrison added this to the 3.3.2 milestone Sep 9, 2016
@mtharrison mtharrison self-assigned this Sep 9, 2016
@mtharrison

This comment has been minimized.

Copy link
Member Author

mtharrison commented Sep 9, 2016

Cool, thanks for the clarification.

@mtharrison mtharrison merged commit 09c75d9 into hapijs:master Sep 9, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mtharrison mtharrison deleted the mtharrison:utf8 branch Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.