Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node 8 issues #84

Merged
merged 3 commits into from May 31, 2017
Merged

Fix node 8 issues #84

merged 3 commits into from May 31, 2017

Conversation

@kanongil
Copy link
Member

kanongil commented May 29, 2017

I decided to test node 8-rc1 against hapi, which cause some of the tests to fail.

I traced the failures back to shot, which also fails it's test-suite, and found backwards compatible fixes to the issues.

The fixing also uncovered an issue where a setHeader() call, before the writeHead() call with extra headers, causes non-lowercase header names to be included in the resulting headers property (on node 7.10). Fortunately, this fix also handles this issue, along with a revised test that detects the issue.

kanongil added 3 commits May 29, 2017
This also fixes a bug where cased headers are included when setHeader() is used before writeHead()
This fixes the "The following leaks were detected:WebAssembly" test error
@mtharrison mtharrison added the bug label May 30, 2017
@mtharrison

This comment has been minimized.

Copy link
Member

mtharrison commented May 30, 2017

Thanks! This looks good to me. I'll give the other reviewers a chance to chime in before merging though.

@mtharrison mtharrison added this to the 3.4.1 milestone May 30, 2017
@mtharrison mtharrison merged commit 0b49877 into hapijs:master May 31, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.