Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for node 8 #85

Merged
merged 1 commit into from May 31, 2017
Merged

Fix for node 8 #85

merged 1 commit into from May 31, 2017

Conversation

@mtharrison
Copy link
Member

mtharrison commented May 31, 2017

From node docs:

If data is specified, it is equivalent to calling response.write(data, encoding) followed by request.end(callback).

This fix should be backwards compatible.

@mtharrison mtharrison added the bug label May 31, 2017
@Marsup
Marsup approved these changes May 31, 2017
@mcollina

This comment has been minimized.

Copy link
Contributor

mcollina commented May 31, 2017

this is terrific, works perfectly. LGTM :)

@Marsup Marsup merged commit 94576e0 into master May 31, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Marsup Marsup deleted the fix-node-8-1 branch May 31, 2017
@mtharrison mtharrison added this to the 3.4.2 milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.