Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lab to v17 to pass on Node v11 #99

Merged
merged 2 commits into from Nov 1, 2018
Merged

Conversation

@mcollina
Copy link
Contributor

mcollina commented Oct 31, 2018

As titled.

@@ -3,6 +3,7 @@ language: node_js
node_js:
- "8"
- "9"

This comment has been minimized.

Copy link
@targos

targos Oct 31, 2018

remove 9 and add 11 instead?

This comment has been minimized.

Copy link
@Marsup

Marsup Oct 31, 2018

Member

11 is already covered by node, I'd remove 9 though.

This comment has been minimized.

Copy link
@mcollina

mcollina Oct 31, 2018

Author Contributor

I typically consider dropping support for a release of Node a semver-major act.

@mtharrison mtharrison merged commit ca062ed into hapijs:master Nov 1, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse added this to the 4.0.5 milestone Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.