Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with example and docs #13

Merged
merged 2 commits into from Aug 26, 2015
Merged

Conversation

@johnbrett
Copy link
Contributor

johnbrett commented Aug 25, 2015

  • Added Example
  • Add docs
@johnbrett

This comment has been minimized.

Copy link
Contributor Author

johnbrett commented Aug 25, 2015

I would like to take maintain this module @hueniverse

README.md Outdated
var Http = require('http');
var Subtext = require('subtext');
Http.createServer(function(request, response) {

This comment has been minimized.

Copy link
@gergoerdosi

gergoerdosi Aug 25, 2015

Add a space after function and use 4 spaces for indentation: https://github.com/hapijs/contrib/blob/master/Style.md

README.md Outdated
Subtext.parse(request, null, { parse: true, output: 'data' }, function(err, parsed) {
response.writeHead(200, {'Content-Type': 'text/plain'});

This comment has been minimized.

Copy link
@gergoerdosi

gergoerdosi Aug 25, 2015

Space after { and before }.

@johnbrett

This comment has been minimized.

Copy link
Contributor Author

johnbrett commented Aug 26, 2015

Thanks for advice @mtharrison and @gergoerdosi, all addressed.

@hueniverse hueniverse self-assigned this Aug 26, 2015
hueniverse added a commit that referenced this pull request Aug 26, 2015
Update README with example and docs
@hueniverse hueniverse merged commit d655353 into hapijs:master Aug 26, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Aug 26, 2015

You are all set with the required permissions.

@johnbrett

This comment has been minimized.

Copy link
Contributor Author

johnbrett commented Aug 26, 2015

Thanks @hueniverse! :)

@johnbrett johnbrett added this to the 2.0.1 milestone Nov 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.