Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't catch synchronous handler errors #9
Conversation
hueniverse
added a commit
that referenced
this pull request
Jul 1, 2015
Don't catch synchronous handler errors
This comment has been minimized.
This comment has been minimized.
|
See test for how to verify the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
connor4312 commentedJun 13, 2015
Previously, synchronous errors in the call stack of
next()(including the route handler, in Hapi servers), were eaten by the try/catch and thrown as "invalid JSON payloads", even though they likely should have been treated as internal server errors.I had difficulty writing a specific test case for this, but the fix does work in our application and does not break any other tests.