Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust hoek to `^8.3.x` #57

Merged
merged 2 commits into from Oct 11, 2019
Merged

Adjust hoek to `^8.3.x` #57

merged 2 commits into from Oct 11, 2019

Conversation

@tuckbick
Copy link
Contributor

tuckbick commented Oct 9, 2019

This change is to use the assert() function exposed by the hoek API rather than reaching for the specific assert file. While the package.json lists @hapi/hoek at version 8.x.x, the @hapi/hoek/lib/assert file was not added until version 8.2.0. This problem affects those with package-lock files where @hapi/hoek is at version < 8.2.0.

@hueniverse hueniverse self-assigned this Oct 9, 2019
@tuckbick

This comment has been minimized.

Copy link
Contributor Author

tuckbick commented Oct 10, 2019

Similarly, @hapi/joi looks for @hapi/address/lib/domain which wasn't added until 2.1.0.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Oct 10, 2019

The solution is to fix package.json file to use ^.

@tuckbick tuckbick force-pushed the tuckbick:hoek branch from f976339 to 3fc7c8a Oct 11, 2019
@tuckbick

This comment has been minimized.

Copy link
Contributor Author

tuckbick commented Oct 11, 2019

Works for me. Updated to adjust package version instead.

@tuckbick tuckbick changed the title Use Hoek.assert() Adjust hoek to `^8.2.x` Oct 11, 2019
@hueniverse hueniverse added this to the 4.0.1 milestone Oct 11, 2019
@hueniverse hueniverse merged commit c2f1bc8 into hapijs:master Oct 11, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hueniverse hueniverse changed the title Adjust hoek to `^8.2.x` Adjust hoek to `^8.3.x` Oct 11, 2019
@tuckbick tuckbick deleted the tuckbick:hoek branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.