Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global context performs deep merge which can produce unexpected results #14

Closed
hueniverse opened this issue Nov 10, 2014 · 2 comments
Closed
Assignees
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Nov 10, 2014

No description provided.

@hueniverse hueniverse self-assigned this Nov 10, 2014
@hueniverse hueniverse added this to the 1.2.1 milestone Nov 10, 2014
@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Nov 10, 2014

I am not sure what to do about this one in terms of versions. The test explicitly allows combining query from the handler and global but this cannot be supported without a deep cloning of the context which is unsafe.

@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Nov 10, 2014

Going to leave this as a bug because this a brand new feature that is breaking for many people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.