404 gives error

[Torsph]

Hi!

It looks like vision gives a error on 404 pages and just hangs the server. I will look into it later, but for now I just thought you should know. Maybe it is some easy error? Or is it related to the updates you are making on the hapi 8.0 release?

Debug: hapi, internal, implementation, error
    TypeError: Cannot read property 'hasOwnProperty' of undefined
    at /Users/Torsph/Development/node/aam/node_modules/hapi/node_modules/vision/lib/index.js:329:20
    at /Users/Torsph/Development/node/aam/node_modules/hapi/node_modules/vision/lib/index.js:432:20
    at Object.engine.compileFunc (/Users/Torsph/Development/node/aam/node_modules/hapi/node_modules/vision/lib/index.js:162:24)
    at /Users/Torsph/Development/node/aam/node_modules/hapi/node_modules/vision/lib/index.js:422:16
    at fs.js:291:14
    at Object.oncomplete (fs.js:97:15)

[Torsph]

So it looks like the context is the problem.

reply.view('some_template'); //Don't work
reply.view('some_template', {}); //Works

In vision/index.js the context is default set to null it will fail on different methods like context.hasOwnProperty. Should it maybe be set to a default empty object? However, will a empty object make the coverage go down because of the code on line 272 in index.js.

[jagoda]

@Torsph It looks to me like this issue only occurs when no global context is supplied, no handler context is supplied, and a layout template is being used. Does that sound consistent with your experience?

Making the default global context an empty object will cause handler supplied context objects to be copied unnecessarily. Instead, what do you think about doing something like context = context || {} after the global context is processed (line 285)?

[Torsph]

@jagoda Thats correct. It is consistent with my experience. Totally agree with you about the unnecessarily copy of the context.

context = context || {} sounds like a good option. I can make the pull request, if you don't want to :)

[jagoda]

Go for it! :-)