Skip to content

/vision

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log errors instead of console.warn() #165

Closed
JSteunou opened this issue Sep 4, 2018 · 4 comments
Closed

Log errors instead of console.warn() #165

JSteunou opened this issue Sep 4, 2018 · 4 comments
Assignees
@hueniverse
Labels
breaking changes bug
Milestone
5.5.0

Comments

@JSteunou
Copy link
Contributor

@JSteunou JSteunou commented Sep 4, 2018

Should this lib use hapijs server log instead of console.log ? I found out that having some not formatted / controled log can be pretty annoying. Had a case when playing with cache invalidation (manager.clearCache)
@wswoodruff

This comment has been minimized.

Sign in to view
Copy link
Contributor

@wswoodruff wswoodruff commented Sep 11, 2018

I'm actually not sure what to do about this one! Looking into it
@wswoodruff wswoodruff added the support label Oct 5, 2018
@hueniverse hueniverse added bug and removed support labels Apr 9, 2019
@hueniverse hueniverse self-assigned this Apr 9, 2019
@hueniverse hueniverse added this to the 5.4.5 milestone Apr 9, 2019
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member

@hueniverse hueniverse commented Apr 9, 2019

No module should log errors to console.
@hueniverse hueniverse changed the title Logging Log errors instead of console.warn() Apr 9, 2019
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member

@hueniverse hueniverse commented Apr 9, 2019

Marked as breaking since the behavior is somewhat different (though no actual breakage).
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member

@hueniverse hueniverse commented Apr 9, 2019

Closed by 0b29418
@hueniverse hueniverse closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hueniverse hueniverse

Labels
breaking changes bug
Projects
None yet
Milestone
  5.5.0
3 participants
@JSteunou @wswoodruff @hueniverse
You can’t perform that action at this time.